Move uncompress_file function from airflow.utils to Hive provider
#43526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
changed the title
uncompress_file from airflow.utils to Hive provideruncompress_file function from airflow.utils to Hive provider
It was only used in S3 To Hive module. One less thing in the `utils` directory.
kaxil
force-pushed
the
move-uncompress
branch
from
77c5f75 to
d9d4fa1
Compare
jscheffl
approved these changes
Oct 30, 2024
eladkal
reviewed
Oct 31, 2024
| from tempfile import NamedTemporaryFile | ||
|
|
||
|
|
||
| def uncompress_file(input_file_name, file_extension, dest_dir): |
There was a problem hiding this comment.
Is this part of the public APi? If so we need newsfargment for Airflow 3 as its a breaking change
There was a problem hiding this comment.
Nope, not a part of the public interface as mentioned in https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…apache#43526) It was only used in S3 To Hive module. One less thing in the `utils` directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used in S3 To Hive module. One less thing in the
utilsdirectory.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.